AnsweredAssumed Answered

adf5355.c Linux driver source bug

Question asked by scarter98 on Jan 11, 2018
Latest reply on Jan 12, 2018 by mhennerich

The latest adf5355.c source file has two bugs.  Edit: Two changes on line 75 needed.

 

Line 75, the mask size is incorrect:

From:

#define ADF4355_REG6_OUTPUTB_PWR(x) (((x) & 0x7) << 4)

To:

#define ADF4355_REG6_OUTPUTB_PWR(x) (((x) & 0x3) << 7)

 

Line 475 is applying the A output power seting to the output B register bits.

From (475 is middle line):

(st->is_5355 ? ADF5355_REG6_RF_OUTB_EN(pdata->outb_en) :
   ADF4355_REG6_OUTPUTB_PWR(pdata->outa_power) |
   ADF4355_REG6_RF_OUTB_EN(pdata->outb_en)) |

To:

(st->is_5355 ? ADF5355_REG6_RF_OUTB_EN(pdata->outb_en) :
   ADF4355_REG6_OUTPUTB_PWR(pdata->outb_power) |
   ADF4355_REG6_RF_OUTB_EN(pdata->outb_en)) |

 

Outcomes