[#5889] toolchain-regtest -r (test compare) option has multiple issues
Submitted By: Mike Frysinger
Open Date
2010-02-08 04:00:22 Close Date
2010-02-09 00:56:33
Priority:
Medium Assignee:
Jie Zhang
Board:
N/A Silicon Revision:
Resolution:
Fixed Fixed In Release:
N/A
Processor:
ALL
Host Operating System:
toolchain rev.:
kernel rev.:
State:
Closed Found In Release:
2010R1
Is this bug repeatable?:
N/A
Summary: toolchain-regtest -r (test compare) option has multiple issues
Details:
the -r option has multiple problems when trying to use it with the simulator
(1)
test results are stored in .../tests/simulator/, but the code that does the comparison (around line 2215) is given a target name of "elf-sim" instead of "simulator" and so it never finds the old tests to compare to.
(2)
if only running simulator tests, the GCC_VERSION variable never gets set so when trying to execute gcc-$GCC_VERSION/contrib/compare_tests, it cant be found.
(3)
the path to -r is supposed to be absolute, but the error message is confusing as it checks for "$RESULTS2COMPARE/$2/$COMP" but then displays "$RESULTS2COMPARE/$2/$FILE" in the error output. this ends up showing double long paths in the error output. i think just the /$FILE needs changing to /$COMP.
Follow-ups
--- Mike Frysinger 2010-02-08 07:31:49
i fixed (3)
there was also a 4th issue: the args to compare_tests were swapped (so it
treated the new tests as the old and the old tests as the new). i fixed that
too though.
not sure how you want to address (1) or (2) ...
--- Mike Frysinger 2010-02-09 00:55:58
i fixed (2) by having it fall back to an automatic search and i just changed all
"simulator" references to "bfin-elf" for (1)
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
No Files Were Found