2008-09-03 08:15:33 CONFIG_SERIAL_BFIN_CTSRTS

Michael McTernan (UNITED KINGDOM)

Message: 61572

The code under CONFIG_SERIAL_BFIN_CTSRTS seems inconsistent across plaforms with a couple configuring rts_pin as an input:

$ grep "uart->rts_pin, 0);" include/asm-blackfin/mach-*/bfin_serial_5xx.h

include/asm-blackfin/mach-bf527/bfin_serial_5xx.h: gpio_direction_output(uart->rts_pin, 0);

include/asm-blackfin/mach-bf533/bfin_serial_5xx.h: gpio_direction_input(uart->rts_pin, 0);

include/asm-blackfin/mach-bf537/bfin_serial_5xx.h: gpio_direction_output(uart->rts_pin, 0);

include/asm-blackfin/mach-bf548/bfin_serial_5xx.h: gpio_direction_output(uart->rts_pin, 0);

include/asm-blackfin/mach-bf561/bfin_serial_5xx.h: gpio_direction_input(uart->rts_pin, 0);

If this right?

QuoteReplyEditDelete

2008-09-03 12:55:54 Re: CONFIG_SERIAL_BFIN_CTSRTS

Mike Frysinger (UNITED STATES)

Message: 61579

that does not look right ... RTS should be output on all platforms

a tracker item has been opened here:

QuoteReplyEditDelete

2008-09-03 13:10:14 Re: CONFIG_SERIAL_BFIN_CTSRTS

Michael McTernan (UNITED KINGDOM)

Message: 61580

Cool - many thanks for confirming.