2009-02-22 20:30:38 spi_bfin5xx.c
Bob Peret (UNITED STATES)
Message: 69729
I didn't have a pullup on my spi CS line and was wondering why it wouldn't go high.
Looks like the driver sets the CS back to a GPIO when the CS is deactivated.
I believe the bold line below should be removed (I am going to add the pullup anyway).
-Bob
static void bfin_spi_cs_deactive(struct driver_data *drv_data, struct chip_data *chip)
{
if (likely(chip->chip_select_num)) {
u16 flag = read_FLAG(drv_data);
flag &= ~chip->flag;
flag |= (chip->flag << 8);
write_FLAG(drv_data, flag);
} else {
gpio_set_value(chip->cs_gpio, 1);
}
/* Move delay here for consistency */
if (chip->cs_chg_udelay)
udelay(chip->cs_chg_udelay);
}
QuoteReplyEditDelete
2009-02-23 10:44:47 Re: spi_bfin5xx.c
Mike Frysinger (UNITED STATES)
Message: 69756
clearing the FLS bit does not set it to GPIO mode. the PORT registers still force it to SPI CS mode.
QuoteReplyEditDelete