[#3888] drivers/net/smsc911x.c broken after 2.6.24 upgrade
Submitted By: Mike Frysinger
Open Date
2008-02-08 09:21:29 Close Date
2008-02-21 01:45:26
Priority:
Medium Assignee:
Bryan Wu
Status:
Closed Fixed In Release:
N/A
Found In Release:
N/A Release:
Category:
N/A Board:
EZKIT Lite
Processor:
BF548 Silicon Revision:
Is this bug repeatable?:
Yes Resolution:
Fixed
Uboot version or rev.:
Toolchain version or rev.:
App binary format:
N/A
Summary: drivers/net/smsc911x.c broken after 2.6.24 upgrade
Details:
after the upgrade to 2.6.24, the network driver for the BF548-EZKIT no longer builds:
vapier@G5[ppc] 0:0 trunk $ make
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/linux/compile.h
CC drivers/net/smsc911x.o
drivers/net/smsc911x.c: In function 'smsc911x_poll':
drivers/net/smsc911x.c:1016: error: 'struct net_device' has no member named 'quota'
drivers/net/smsc911x.c:1016: warning: type defaults to 'int' in declaration of '_x'
drivers/net/smsc911x.c:1016: error: 'struct net_device' has no member named 'quota'
drivers/net/smsc911x.c:1069: error: 'struct net_device' has no member named 'quota'
drivers/net/smsc911x.c:1075: error: too few arguments to function 'netif_rx_complete'
drivers/net/smsc911x.c: In function 'smsc911x_irqhandler':
drivers/net/smsc911x.c:1542: error: too few arguments to function 'netif_rx_schedule'
drivers/net/smsc911x.c: In function 'smsc911x_init':
drivers/net/smsc911x.c:2025: error: 'struct net_device' has no member named 'poll'
drivers/net/smsc911x.c:2026: error: 'struct net_device' has no member named 'weight'
drivers/net/smsc911x.c: In function 'smsc911x_drv_probe':
drivers/net/smsc911x.c:2113: error: implicit declaration of function 'SET_MODULE_OWNER'
make[2]: *** [drivers/net/smsc911x.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Follow-ups
--- Bryan Wu 2008-02-17 22:12:25
I will fix it.
It's broken, because of NAPI change
git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bea3348eef27e6044b6161fd04c3152215f96411
[NET]: Make NAPI polling independent of struct net_device objects.
-Bryan
--- Bryan Wu 2008-02-18 03:15:54
it was fixed in svn trunk.
-Bryan
--- Bryan Wu 2008-02-21 01:45:26
close it.
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
No Files Were Found