[#3957] bootmem code shadows global max_pfn
Submitted By: Mike Frysinger
2008-03-05 14:25:23 Close Date
Closed Fixed In Release:
Found In Release:
N/A Silicon Revision:
Is this bug repeatable?:
Uboot version or rev.:
Toolchain version or rev.:
App binary format:
Summary: bootmem code shadows global max_pfn
we have a local variable "max_pfn":
arch/blackfin/kernel/setup.c: unsigned long min_pfn, max_pfn;
but common linux code has:
include/linux/bootmem.h:extern unsigned long max_pfn;
something is out of sync ...
--- Yi Li 2008-03-06 02:51:21
Yes. We need to find a place to initialize these globals.
Searched linux-188.8.131.52 source tree, found that there a few places in common
code uses the global max_pfn:
As the notes in arch/arm/mm/init.c: bootmem_init() mentions:
""This doesn't seem to be used by the Linux memory manager anymore,
but is used by ll_rw_block".
--- Yi Li 2008-03-13 03:05:42
There are a number of MM related globals:
initialized in arch/blackfin/kernel/setup.c:
linux/bootmem.h: max_pfn, min_low_pfn, max_low_pfn
initialized in arch/blackfin/mm/init.c:
linux/mm.h: max_mapnr, num_physpages, high_memory
It is rather confusing to understand what they exactly mean.
File Name File Type File Size Posted By
No Files Were Found