[#4059] drivers/char/bfin_sport.c fails to build when DEBUG is defined
Submitted By: John Lee
Open Date
2008-04-24 11:06:55 Close Date
2008-06-19 01:48:07
Priority:
Medium High Assignee:
Cliff Cai
Status:
Closed Fixed In Release:
N/A
Found In Release:
N/A Release:
uClinux-dist-2008R1-RC8
Category:
N/A Board:
N/A
Processor:
N/A Silicon Revision:
Is this bug repeatable?:
Yes Resolution:
Fixed
Uboot version or rev.:
Toolchain version or rev.:
blackfin-toolchain-2008R1-RC8
App binary format:
N/A
Summary: drivers/char/bfin_sport.c fails to build when DEBUG is defined
Details:
CC drivers/char/misc.o
CC sound/core/timer.o
CC drivers/char/bfin_sport.o
LD [M] fs/smbfs/smbfs.o
CC [M] fs/yaffs2/yaffs_fs.o
drivers/char/bfin_sport.c: In function ‘dump_dma_regs’:
drivers/char/bfin_sport.c:604: error: dereferencing pointer to incomplete type
drivers/char/bfin_sport.c:605: error: dereferencing pointer to incomplete type
drivers/char/bfin_sport.c:605: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/char/bfin_sport.o] Error 1
make[2]: *** [drivers/char] Error 2
make[1]: *** [drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
CC sound/core/sound.o
In file included from include/linux/interrupt.h:15,
from fs/yaffs2/yaffs_fs.c:51:
Follow-ups
--- John Lee 2008-04-24 11:13:59
When I add
#define DEBUG
in file "include/linux/device.h"
this error happend.
--- Mike Frysinger 2008-04-24 15:53:48
you should not be adding '#define DEBUG' to random headers. in order to use it
properly, you have to put it at the top of whatever .c file you want to enable
debugging in.
just dont enable DEBUG for the sport driver and it'll build fine
--- Cliff Cai 2008-06-12 03:42:42
Just as Mike mentioned,if you want to debug this driver,add '#define DEBUG'
on the top of the file bfin_sport_uart.c
Cliff
--- Mike Frysinger 2008-06-12 03:59:15
this is about bfin_sport.c, not bfin_sport_uart.c. the bfin_sport.c has an
error in it which will be hit when you define DEBUG. unless i missed something,
the bfin_sport.c file has not been fixed.
--- Cliff Cai 2008-06-18 23:38:07
Sorry for carelessness,I will take a look.
Cliff
--- Cliff Cai 2008-06-19 01:48:06
Fixed it.struct dma_register_t should be struct dma_register.
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
bfin_sport.c text/x-csrc 21620 John Lee