[#4093] twidfftrad2_fr16 _cos reference broken again in 2008 release

Submitted By: Michael Johnson

Open Date

2008-05-08 11:44:54 Close Date

2009-03-03 02:52:33

Priority:

Medium Assignee:

Jie Zhang

Status:

Closed Fixed In Release:

N/A

Found In Release:

2008R1-RC8 Release:

2008R1-RC8

Category:

N/A Board:

N/A

Processor:

ALL Silicon Revision:

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

08r1

App binary format:

N/A

Summary: twidfftrad2_fr16 _cos reference broken again in 2008 release

Details:

I recently upgraded to the 2008R1-RC8 release, and have found the twidfftrad2_fr16() function fails to link. The error given is an undefined reference to _cos and _sin.

A search of the forums revealed this was a problem in 2007, and was fixed by adding #include <math_bf.h> to twidfftrad2_fr16.c file. (Bug Tracker 2794)

I checked the difference between the twidfftrad2_fr16.c file between 2007R1-RC3 and 2008R1-RC8, and the major difference is the missing #include. I added it to my file, rebuilt the library, and it now links.

Follow-ups

--- Jie Zhang 2008-05-20 06:13:04

Sorry, I broke it. I tried to include math_bf.h in math.h to mimic VDSP

convention. But then I was pointed that it was not a good practice, since it

polluted standard headers. So I reverted my changes but forgot to include

math_bf.h in C files which need it. I'll fix it soon.

To prevent this bug happen again, I need a test case to add it to our

testsuite. It's hard for me to write a test case using twidfftrad2_fr16 not

trivially. So coud you provide a small test case for us? Or I'll write a test

case which only checks compilation error.

--- Jie Zhang 2008-05-20 06:16:42

Never bother to write the test case. I have got one.