[#4268] Use mouse button click to past strings to serial console may cause uart driver overrun

Submitted By: Graf Yang

Open Date

2008-07-22 02:05:01 Close Date

2008-08-01 07:44:57

Priority:

Low Assignee:

Graf Yang

Status:

Closed Fixed In Release:

N/A

Found In Release:

N/A Release:

trunk

Category:

Drivers Board:

N/A

Processor:

ALL Silicon Revision:

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

App binary format:

N/A

Summary: Use mouse button click to past strings to serial console may cause uart driver overrun

Details:

When UART driver in PIO mode, past string that are near to 80 characters, the string may incorrect, or driver said it's overrun.

Follow-ups

--- Sonic Zhang 2008-07-22 02:23:54

You need to describe detail steps and setting.

which release version? what board? what's the wrong data? What's the expected

result?

--- Graf Yang 2008-07-22 03:04:10

I use the trunk and BF537, BF561 also have this issue.

Use mouse select some sentence(hold left button, move mouse on some string),

click middle button in the blackfin serial console window, the selected sentence

will be pasted into console window.

If the sentence is long, such as 70 characters, the pasted sentence may lost ,

repeat some characters, or the console say overrun.

I think we can modify the bfin_serial_stop_tx(), only check the THRE bit, not

check the TEMT bit. Because, when the last byte is moved to TSR from UARTx_THR,

bfin_serial_tx_int() is called, which will call bfin_serial_stop_tx(), at this

point, the last byte is still sending from TSR, this may take 0.173ms (for baud

rate 57600), it's a chunk of time for the core.

--- Sonic Zhang 2008-07-22 04:41:53

Fixed.

--- Sonic Zhang 2008-07-22 04:43:09

Fixed.

Don't call bfin_serial_stop_tx() from tx_transfer. Disable tx interrupt and

return immediately instead.

--- Graf Yang 2008-08-01 07:44:57

It is fixed by Sonic.

Files

Changes

Commits

Dependencies

Duplicates

Associations