[#5015] kernel build fails when adp5520 is built into kernel but i2c is a module

Submitted By: Mike Frysinger

Open Date

2009-03-25 22:59:55 Close Date

2009-04-08 22:12:01

Priority:

Low Assignee:

Michael Hennerich

Status:

Closed Fixed In Release:

N/A

Found In Release:

snaps Release:

Category:

N/A Board:

N/A

Processor:

ALL Silicon Revision:

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

trunk

App binary format:

N/A

Summary: kernel build fails when adp5520 is built into kernel but i2c is a module

Details:

i dont know if we want to make adp5520 a tristate, or make the dependency read like other multifunction devices:

depends on I2C=y

otherwise we end up with errors like:

drivers/built-in.o: In function `__adp5520_read':

drivers/mfd/adp5520.c:(.text+0x29300): undefined reference to `i2c_smbus_read_byte_data'

drivers/built-in.o: In function `__adp5520_write':

drivers/mfd/adp5520.c:(.text+0x2935a): undefined reference to `i2c_smbus_write_byte_data'

drivers/built-in.o: In function `adp5520_init':

drivers/mfd/adp5520.c:(.init.text+0x1fbc): undefined reference to `i2c_register_driver'

make: *** [.tmp_vmlinux1] Error 1

Follow-ups

--- Michael Hennerich 2009-03-26 06:23:47

Thanks

Fixed on trunk.

-Michael

Files

Changes

Commits

Dependencies

Duplicates

Associations