[#5207] SPI driver fails to build in trunk

Submitted By: Michael Hennerich

Open Date

2009-06-04 05:55:16 Close Date

2009-06-05 08:14:04

Priority:

Medium Assignee:

Yi Li

Status:

Closed Fixed In Release:

N/A

Found In Release:

2010R1 Release:

Category:

Drivers Board:

EZKIT Lite

Processor:

BF548 Silicon Revision:

any

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

any

App binary format:

N/A

Summary: SPI driver fails to build in trunk

Details:

SPI driver fails to build on trunk:

The IRQ# should come from struct resource and not being hardcoded to IRQ_SPI.

First of all this driver supports multiple SPIs - and IRQ_SPI is only defined on machines with 1 SPI.

-Michael

drivers/spi/spi_bfin5xx.c: In function ‘bfin_spi_pio_irq_handler’:

drivers/spi/spi_bfin5xx.c:565: error: ‘IRQ_SPI’ undeclared (first use in this function)

drivers/spi/spi_bfin5xx.c:565: error: (Each undeclared identifier is reported only once

drivers/spi/spi_bfin5xx.c:565: error: for each function it appears in.)

drivers/spi/spi_bfin5xx.c: In function ‘bfin_spi_pump_transfers’:

drivers/spi/spi_bfin5xx.c:949: error: ‘IRQ_SPI’ undeclared (first use in this function)

drivers/spi/spi_bfin5xx.c: In function ‘bfin_spi_setup’:

drivers/spi/spi_bfin5xx.c:1315: error: ‘IRQ_SPI’ undeclared (first use in this function)

CC [M] fs/nfsd/nfs3proc.o

drivers/spi/spi_bfin5xx.c: In function ‘bfin_spi_remove’:

drivers/spi/spi_bfin5xx.c:1604: error: ‘IRQ_SPI’ undeclared (first use in this function)

make[3]: *** [drivers/spi/spi_bfin5xx.o] Error 1

Follow-ups

--- Yi Li 2009-06-05 07:51:57

Should be fixed on trunk now.

--- Michael Hennerich 2009-06-05 08:14:04

Thanks!

Close it.

-Michael

Files

Changes

Commits

Dependencies

Duplicates

Associations