[#5241] drivers/media/video/blackfin/blackfin_cam.c build fails after linux-2.6.30 upgrade
Submitted By: Mike Frysinger
Open Date
2009-06-11 09:03:27 Close Date
2009-07-14 12:12:42
Priority:
Medium Assignee:
Michael Hennerich
Status:
Closed Fixed In Release:
N/A
Found In Release:
2010R1 Release:
Category:
N/A Board:
N/A
Processor:
ALL Silicon Revision:
Is this bug repeatable?:
Yes Resolution:
Fixed
Uboot version or rev.:
Toolchain version or rev.:
trunk
App binary format:
N/A
Summary: drivers/media/video/blackfin/blackfin_cam.c build fails after linux-2.6.30 upgrade
Details:
looks like video_usercopy() has changed prototypes
drivers/media/video/blackfin/blackfin_cam.c:1324: warning: passing argument 1 of ‘video_usercopy’ from incompatible pointer type
drivers/media/video/blackfin/blackfin_cam.c:1324: warning: passing argument 2 of ‘video_usercopy’ makes integer from pointer without a cast
drivers/media/video/blackfin/blackfin_cam.c:1324: warning: passing argument 4 of ‘video_usercopy’ makes pointer from integer without a cast
drivers/media/video/blackfin/blackfin_cam.c:1324: error: too many arguments to function ‘video_usercopy’
drivers/media/video/blackfin/blackfin_cam.c: At top level:
drivers/media/video/blackfin/blackfin_cam.c:1377: warning: initialization from incompatible pointer type
make[4]: *** [drivers/media/video/blackfin/blackfin_cam.o] Error 1
Follow-ups
--- Peter Meerwald 2009-07-14 11:45:02
build is fixed by the following patch; I have no camera yet to test
functionality
pmeerw@pmeerw-pc:~/et908/linux-kernel$ svn diff
drivers/media/video/blackfin/blackfin_cam.c
Index: drivers/media/video/blackfin/blackfin_cam.c
===================================================================
--- drivers/media/video/blackfin/blackfin_cam.c (revision 7003)
+++ drivers/media/video/blackfin/blackfin_cam.c (working copy)
@@ -1321,7 +1321,7 @@
static int bcap_ioctl(struct inode *inode, struct file *filp, unsigned int
cmd,
unsigned long arg)
{
- return video_usercopy(inode, filp, cmd, arg, (void *)v4l_ioctl);
+ return video_usercopy(filp, cmd, arg, (void *)v4l_ioctl);
}
static int bcap_mmap(struct file *filp, struct vm_area_struct *vma)
--- Mike Frysinger 2009-07-14 12:12:42
ive fixed the build warnings/errors, but i havent tested any of it
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
No Files Were Found