[#5381] USB:SL811 fails to disconnect upon device removal

Submitted By: Michael Hennerich

Open Date

2009-07-22 07:37:53 Close Date

2009-07-24 03:36:50

Priority:

Medium Assignee:

Michael Hennerich

Status:

Closed Fixed In Release:

N/A

Found In Release:

N/A Release:

2009R1

Category:

Drivers Board:

STAMP

Processor:

ALL Silicon Revision:

0.3

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

2009R1

App binary format:

N/A

Summary: USB:SL811 fails to disconnect upon device removal

Details:

USB:SL811 fails to disconnect upon device removal

This issue was reported here:

http://blackfin.uclinux.org/gf/project/uclinux-dist/forum/?action=ForumBrowse&_forum_action=MessageReply&message_id=76148

I could verify that this bug exist on 2009R1 and trunk

Follow-ups

--- Michael Hennerich 2009-07-22 07:40:05

I've been looking into this issue fort he last hours. It appears to be some

interaction between sl811 hub status changes and generic code in usb/core/hub.c

Still digging.

--- Michael Hennerich 2009-07-22 10:18:54

Fixed on trunk and branch 2009R1

SL811 Device detect after removal used to be working in linux-2.6.22 but then

broke somewhere between 2.6.22 and 2.6.28. Current hub_port_connect_change() in

drivers/usb/core/hub.c won't call usb_disconnect() in case the SL811 driver sets

portstatus USB_PORT_FEAT_CONNECTION upon removal.

As far as I know the SL811 has only a combined Device Insert/Remove Detection

bit, therefore use a count to distinguish insert or remove.

-Michael

--- Michael Hennerich 2009-07-24 03:36:50

Hi Mike,

This fix in svn rev. 7061 needs to be send upstream.

Close this bug now.

-Michael

Files

Changes

Commits

Dependencies

Duplicates

Associations