[#5763] make config for trunk head kernel with script fails at Atmel SD/MMC Driver for mismatch

Submitted By: Mingquan Pan

Open Date

2009-12-09 22:49:14 Close Date

2009-12-10 22:07:28

Priority:

Medium Assignee:

Mike Frysinger

Status:

Closed Fixed In Release:

N/A

Found In Release:

2010R1 Release:

Category:

N/A Board:

N/A

Processor:

BF548 Silicon Revision:

Is this bug repeatable?:

Yes Resolution:

Fixed

Uboot version or rev.:

Toolchain version or rev.:

4.1 trunk head

App binary format:

N/A

Summary: make config for trunk head kernel with script fails at Atmel SD/MMC Driver for mismatch

Details:

make config for trunk head kernel with script fails at Atmel SD/MMC Driver for mismatch in format.

Normally we expect a discription with an (CONFIG) and [Y/N] , but here no config name behind and in the Kconfig file , it says it is choice:

* MMC/SD/SDIO Host Controller Drivers^M

*^M

Secure Digital Host Controller Interface support (MMC_SDHCI) [N/m/y/?] ^M

Atmel SD/MMC Driver [M/y/?]

choice

prompt "Atmel SD/MMC Driver"

default MMC_ATMELMCI if AVR32

help

Choose which driver to use for the Atmel MCI Silicon

config MMC_AT91

tristate "AT91 SD/MMC Card Interface support"

help

This selects the AT91 MCI controller.

If unsure, say N.

config MMC_ATMELMCI

tristate "Atmel Multimedia Card Interface support"

help

This selects the Atmel Multimedia Card Interface driver. If

you have an AT32 (AVR32) or AT91 platform with a Multimedia

Card slot, say Y or M here.

If unsure, say N.

endchoice

So the config has some error in format.

Follow-ups

--- Mike Frysinger 2009-12-10 07:56:33

this is possibly correct behavior. choices can be given keywords such that you

can choose to disable all, enable multiple ones, or select just one (the

default). so you should probably fix your scripts to always answer the default

to these prompts so that the sub config options are also prompted for.

you didnt show the whole Kconfig file in question though. in this case, it

doesnt make much sense to show the prompt since all children are disabled for

Blackfin systems (only work on avr/arm). it also shouldnt have a M option as

this is cascading from the parent tristate instead of the default bool.

--- Mike Frysinger 2009-12-10 09:26:59

ive fixed it so that the prompt isnt shown when no children exist. otherwise,

you might be prompted like so:

Atmel SD/MMC Driver [M/y] (NEW)

a M here means you want to build multiple drivers as modules:

AT91 SD/MMC Card Interface support (MMC_AT91) [N/m] (NEW)

AT91 SD/MMC Card Interface support (MMC_AT91f) [N/m] (NEW)

while a Y here means you want to build one driver into the kernel:

> 1. AT91 SD/MMC Card Interface support (MMC_AT91) (NEW)

2. AT91 SD/MMC Card Interface support (MMC_AT91f) (NEW)

i imagine the default ("M") should be fine for your autoconfig needs

--- Mingquan Pan 2009-12-10 22:07:28

All right, this fix works with the current script. Thanks. Close.

Files

Changes

Commits

Dependencies

Duplicates

Associations