[#4741] test suite: usbhost_bf5xx_test.exp does not set chip revision correctly
Submitted By: Yi Li
Open Date
2008-12-22 22:55:59 Close Date
2009-01-06 06:14:46
Priority:
Medium Assignee:
Vivi Li
Status:
Closed Fixed In Release:
N/A
Found In Release:
N/A Release:
Category:
N/A Board:
EZKIT Lite
Processor:
BF549 Silicon Revision:
Is this bug repeatable?:
Yes Resolution:
Fixed
Uboot version or rev.:
Toolchain version or rev.:
App binary format:
N/A
Summary: test suite: usbhost_bf5xx_test.exp does not set chip revision correctly
Details:
This script always configure BF548 chip revision in kernel as 0.0, while actually the regression test is performed on a BF548-EZkit with 0.1 silicon revision. We may need to update the script or add an option to specify silicon revision.
Follow-ups
--- Yi Li 2008-12-22 23:02:51
Should be: build_usbhost_bf5xx_kernel.exp.
--- Robin Getz 2008-12-23 18:12:03
Is is practical to use cat /proc/cpuid - to get the device under test target
info? (CPU, board, and rev)?
-Robin
--- Vivi Li 2008-12-24 04:32:41
Robin:
I guess you mean that we get the target info from /proc/cpuid and then feed
these parameters back to build scripts.
I don't think it's necessary as we have a specific file on each test machine. I
can set revision there and it will pass the parameter to build scripts.
And I have already fixed it.
--- Robin Getz 2008-12-24 11:45:32
Vivi:
> I guess you mean that we get the target info from /proc/cpuid and then
> feed these parameters back to build scripts.
Yes - this would make the scripts more general purpose - you could update the
device under test connected to the test PC, and not need to touch the scripts on
the PC...
> I don't think it's necessary as we have a specific file on each test
machine.
> I can set revision there and it will pass the parameter to build scripts.
Yeah, I guess the question is - is it more/less work to make something general
purpose, or to just modify the scripts every time the DUT changes.
Up to you.
-Robin
--- Sonic Zhang 2008-12-28 22:28:45
Make things more generic may introduce bug into script. Put configuration on
each test machine is a bit simple, since they are rarely changed.
--- Vivi Li 2009-01-06 06:14:46
Close it.
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
No Files Were Found