[#6418] The user/procps/Makefile copies the entire contents of user/procps to ROMFS/lib/
Submitted By: Reggy Perrin
Open Date
2010-12-21 14:46:02
Priority:
Medium Assignee:
Nobody
Status:
Open Fixed In Release:
N/A
Found In Release:
2010R1-RC5 Release:
Category:
uClinux-dist applications Board:
N/A
Processor:
ALL Silicon Revision:
Is this bug repeatable?:
Yes Resolution:
Fixed
Uboot version or rev.:
Toolchain version or rev.:
bfin-uclinux-gcc (ADI/svn-4960
App binary format:
Shared FLAT
Summary: The user/procps/Makefile copies the entire contents of user/procps to ROMFS/lib/
Details:
This is strictly when you build with shared FDPIC support. The user/procps/Makefile is trying to copy .so files to ROMFS/lib, when none are built, it copies all the source code to ROMFS/lib:
root:/> ls /lib
COPYING libcrypt.so.0 libutil.so.0 slab.c
alloc.c libdl.so.0 libz.so.1 slab.h
alloc.h libgcc_s.so.1 module.mk sysinfo.c
devname.c libm.so.0 modules sysinfo.h
devname.h libncurses.so.5 procps.h version.c
escape.c libpthread.so.0 pwcache.c version.h
escape.h library.map pwcache.h wchan.h
firmware libresolv.so.0 readproc.c whattime.c
ksym.c librt.so.0 readproc.h whattime.h
ld-uClibc.so.0 libstdc++.so.6 sig.c
libc.so.0 libthread_db.so.1 sig.h
To correct, I patched as follows:
from:
romfs:
ifeq ($(SHARED),1)
lib=`basename $(wildcard $(VER)/proc/libproc-*.so)` ; \
$(ROMFSINST) $(VER)/proc/$$lib /lib/$$lib
endif
to:
romfs:
ifeq ($(SHARED),1)
for f in `find $(VER)/proc -name 'libproc-*.so'` ; do \
$(ROMFSINST) $(VER)/proc/$$f /lib/$$f ; \
done
endif
However, I cannot confirm that this properly handles the .so files (as our build isn't building them). However, this was modeled after the ppp Makefile, so it should be comparable.
Follow-ups
--- Mike Frysinger 2010-12-21 15:35:13
about the only way this could happen is if you only enable watch. otherwise,
there has to be a shared libproc. please post the actual config you're using.
--- Reggy Perrin 2010-12-21 16:39:34
Mike,
We are only enabling 'ps'. Would that generate this?
--- Mike Frysinger 2010-12-21 19:06:50
yes, it should. but that brings up the real source of the problem ... the
procps/Makefile doesnt respect the CONFIG_USER_PROCPS_PS option.
ive fixed this in svn branch and trunk
Files
Changes
Commits
Dependencies
Duplicates
Associations
Tags
File Name File Type File Size Posted By
No Files Were Found