[#5482] using C++/C99 comments breaks linker script generation

Document created by Aaronwu Employee on Sep 25, 2013
Version 1Show Document
  • View in full screen mode

[#5482] using C++/C99 comments breaks linker script generation

Submitted By: Vivi Li

Open Date

2009-09-02 19:13:46     Close Date

2009-09-02 19:57:20

Priority:

Medium High     Assignee:

Mike Frysinger

Category:

N/A     Fixed In Release:

N/A

Found In Release:

N/A     Status:

Closed

Board:

N/A     Processor:

BF548

Silicon Revision:

    Resolution:

Rejected

Is the bug repeatable?:

N/A     

Summary: using C++/C99 comments breaks linker script generation

Details:

 

I need to reduce u-boot.ldr size, so I disable CONFIG_VIDEO in bf548-ezkit in latest 2009.08 u-boot, and it fails to build.

 

It can build in 2009.06.

 

--

Index: include/configs/bf548-ezkit.h

===================================================================

--- include/configs/bf548-ezkit.h       (revision 2024)

+++ include/configs/bf548-ezkit.h       (working copy)

@@ -188,9 +188,9 @@

 

#ifndef __ADSPBF542__

/* Don't waste time transferring a logo over the UART */

-# if (CONFIG_BFIN_BOOT_MODE != BFIN_BOOT_UART)

-#  define CONFIG_VIDEO

-# endif

+//# if (CONFIG_BFIN_BOOT_MODE != BFIN_BOOT_UART)

+//#  define CONFIG_VIDEO

+//# endif

# define CONFIG_DEB_DMA_URGENT

#endif

--

 

--

UNDEF_SYM=`bfin-uclinux-objdump -x board/bf548-ezkit/libbf548-ezkit.a lib_generic/libgeneric.a lib_generic/lzma/liblzma.a lib_generic/lzo/liblzo.a cpu/blackfin/libblackfin.a lib_blackfin/libblackfin.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a fs/yaffs2/libyaffs2.a fs/ubifs/libubifs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/fpga/libfpga.a drivers/gpio/libgpio.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mmc/libmmc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/onenand/libonenand.a drivers/mtd/ubi/libubi.a drivers/mtd/spi/libspi_flash.a drivers/net/libnet.a drivers/net/phy/libphy.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/power/libpower.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/twserial/libtws.a drivers/usb/gadget/libusb_gadget.a drivers/usb/host/libusb_host.a drivers/usb/musb/libusb_musb.a drivers/video/libvideo.a drivers/watchdog/libwatchdog.a common/libcommon.a libfdt/libfdt.a api/libapi.a post/libpost.a | sed  -n -e 's/.*\(___u_boot_cmd_.*\)/-u\1/p'|sort|uniq`; cd /home/test/work/cruise/checkouts/u-boot/u-boot-2009.08 && bfin-uclinux-ld --gc-sections -Bstatic -T u-boot.lds  $UNDEF_SYM cpu/blackfin/start.o --start-group lib_generic/libgeneric.a lib_generic/lzma/liblzma.a lib_generic/lzo/liblzo.a cpu/blackfin/libblackfin.a lib_blackfin/libblackfin.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a fs/yaffs2/libyaffs2.a fs/ubifs/libubifs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/fpga/libfpga.a drivers/gpio/libgpio.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mmc/libmmc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/onenand/libonenand.a drivers/mtd/ubi/libubi.a drivers/mtd/spi/libspi_flash.a drivers/net/libnet.a drivers/net/phy/libphy.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/power/libpower.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/twserial/libtws.a drivers/usb/gadget/libusb_gadget.a drivers/usb/host/libusb_host.a drivers/usb/musb/libusb_musb.a drivers/video/libvideo.a drivers/watchdog/libwatchdog.a common/libcommon.a libfdt/libfdt.a api/libapi.a post/libpost.a board/bf548-ezkit/libbf548-ezkit.a --end-group -L /opt/uClinux/bfin-uclinux/lib/gcc/bfin-uclinux/4.1.2 -lgcc -Map u-boot.map -o u-boot

/opt/uClinux/bfin-uclinux/bin/bfin-uclinux-ld.real:u-boot.lds:1: ignoring invalid character `#' in expression

/opt/uClinux/bfin-uclinux/bin/bfin-uclinux-ld.real:u-boot.lds:1: syntax error

make[1]: *** [u-boot] Error 1

make[1]: Leaving directory `/home/test/work/cruise/checkouts/u-boot/u-boot-2009.08'

make: *** [bf548-ezkit] Error 2

--

 

Follow-ups

 

--- Mike Frysinger                                           2009-09-03 00:36:52

dont use // style comments and it'll work fine

 

--- Mike Frysinger                                           2009-09-03 00:39:37

mainline uses -ansi for the preprocessing on purpose and wolfgang isnt going to

change his mind on this.  // is not valid comment style in ansi code.

 

--- Vivi Li                                                  2009-09-03 00:58:27

Yeah, it works after I changed the comment style.

So close this bug.

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

No Files Were Found

Attachments

    Outcomes