[#4196] wrong defines in u-boot/include/asm-blackfin/mach-bf548/ports.h

Document created by Aaronwu Employee on Sep 25, 2013
Version 1Show Document
  • View in full screen mode

[#4196] wrong defines in u-boot/include/asm-blackfin/mach-bf548/ports.h

Submitted By: Ben Maan

Open Date

2008-06-25 02:11:52     Close Date

2008-07-03 13:50:32

Priority:

Low     Assignee:

Mike Frysinger

Category:

N/A     Fixed In Release:

N/A

Found In Release:

N/A     Status:

Closed

Board:

N/A     Processor:

N/A

Silicon Revision:

    Resolution:

Fixed

Is the bug repeatable?:

N/A     

Summary: wrong defines in u-boot/include/asm-blackfin/mach-bf548/ports.h

Details:

 

In u-boot/include/asm-blackfin/mach-bf548/ports.h the defines for PORT_x_MUX_8_FUNC_1 till PORT_x_MUX_15_FUNC_4 are the same.

It should be:

#define PORT_x_MUX_8_FUNC_1    (PORT_x_MUX_FUNC_1 << 16)

#define PORT_x_MUX_8_FUNC_2    (PORT_x_MUX_FUNC_2 << 16)

#define PORT_x_MUX_8_FUNC_3    (PORT_x_MUX_FUNC_3 << 16)

#define PORT_x_MUX_8_FUNC_4    (PORT_x_MUX_FUNC_4 << 16)

#define PORT_x_MUX_9_FUNC_1    (PORT_x_MUX_FUNC_1 << 18)

#define PORT_x_MUX_9_FUNC_2    (PORT_x_MUX_FUNC_2 << 18)

#define PORT_x_MUX_9_FUNC_3    (PORT_x_MUX_FUNC_3 << 18)

#define PORT_x_MUX_9_FUNC_4    (PORT_x_MUX_FUNC_4 << 18)

#define PORT_x_MUX_10_FUNC_1    (PORT_x_MUX_FUNC_1 << 20)

#define PORT_x_MUX_10_FUNC_2    (PORT_x_MUX_FUNC_2 << 20)

#define PORT_x_MUX_10_FUNC_3    (PORT_x_MUX_FUNC_3 << 20)

#define PORT_x_MUX_10_FUNC_4    (PORT_x_MUX_FUNC_4 << 20)

#define PORT_x_MUX_11_FUNC_1    (PORT_x_MUX_FUNC_1 << 22)

#define PORT_x_MUX_11_FUNC_2    (PORT_x_MUX_FUNC_2 << 22)

#define PORT_x_MUX_11_FUNC_3    (PORT_x_MUX_FUNC_3 << 22)

#define PORT_x_MUX_11_FUNC_4    (PORT_x_MUX_FUNC_4 << 22)

#define PORT_x_MUX_12_FUNC_1    (PORT_x_MUX_FUNC_1 << 24)

#define PORT_x_MUX_12_FUNC_2    (PORT_x_MUX_FUNC_2 << 24)

#define PORT_x_MUX_12_FUNC_3    (PORT_x_MUX_FUNC_3 << 24)

#define PORT_x_MUX_12_FUNC_4    (PORT_x_MUX_FUNC_4 << 24)

#define PORT_x_MUX_13_FUNC_1    (PORT_x_MUX_FUNC_1 << 26)

#define PORT_x_MUX_13_FUNC_2    (PORT_x_MUX_FUNC_2 << 26)

#define PORT_x_MUX_13_FUNC_3    (PORT_x_MUX_FUNC_3 << 26)

#define PORT_x_MUX_13_FUNC_4    (PORT_x_MUX_FUNC_4 << 26)

#define PORT_x_MUX_14_FUNC_1    (PORT_x_MUX_FUNC_1 << 28)

#define PORT_x_MUX_14_FUNC_2    (PORT_x_MUX_FUNC_2 << 28)

#define PORT_x_MUX_14_FUNC_3    (PORT_x_MUX_FUNC_3 << 28)

#define PORT_x_MUX_14_FUNC_4    (PORT_x_MUX_FUNC_4 << 28)

#define PORT_x_MUX_15_FUNC_1    (PORT_x_MUX_FUNC_1 << 30)

#define PORT_x_MUX_15_FUNC_2    (PORT_x_MUX_FUNC_2 << 30)

#define PORT_x_MUX_15_FUNC_3    (PORT_x_MUX_FUNC_3 << 30)

#define PORT_x_MUX_15_FUNC_4    (PORT_x_MUX_FUNC_4 << 30)

 

Follow-ups

 

--- Mike Frysinger                                           2008-06-25 07:37:57

erp, looks like i got lazy once i started copying and pasting the higher values

 

should be fixed in svn now, thanks

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

No Files Were Found

Attachments

    Outcomes