2009-12-04 09:52:51 musb_platform_init() has board-specific register inits
Rutger Hofman (NETHERLANDS)
Good afternoon list,
on our new custom hardware (http://www.rfidguardian.org) we have a BF547 and USB. Now, in musb_platform_init() in file drivers/usb/blackfin_usb.c (in the 2009R1 release) has code that is specific to the BF54x EZ-Kits. The host mode is selected by setting PE7 high on that board. However, on our board that is controlled through setting PA14 low.
Shouldn't the board specifics be moved into board/bf548-ezkit/somewhere.c, and have the functionality be exported through a call to something like usb_host_pin_enable() or whatever? Something similar might apply to the BF52x boards.
2009-12-04 10:06:52 Re: musb_platform_init() has board-specific register inits
Robin Getz (UNITED STATES)
Yes - you are correct - there shouldn't be any platform specific code in the driver. That slipped in when we were doing the initial development.
I needs to be split up proplery (like you suggest).
2009-12-08 02:41:58 Re: musb_platform_init() has board-specific register inits
Cliff Cai (CHINA)
thanks for your information,I've moved such board specific to related board files in trunk head.