[#4459] a bug in serial driver

Document created by Aaronwu Employee on Aug 29, 2013
Version 1Show Document
  • View in full screen mode

[#4459] a bug in serial driver

Submitted By: Qian Zhang

Open Date

2008-10-08 00:07:20     Close Date

2009-03-03 03:15:12

Priority:

Medium     Assignee:

Sonic Zhang

Status:

Closed     Fixed In Release:

N/A

Found In Release:

2008R1-RC8     Release:

Category:

Drivers     Board:

N/A

Processor:

ALL     Silicon Revision:

Is this bug repeatable?:

Yes     Resolution:

Fixed

Uboot version or rev.:

    Toolchain version or rev.:

09r1

App binary format:

N/A     

Summary: a bug in serial driver

Details:

 

in drivers/serial/bfin_5xx.c

 

function bfin_serial_dma_rx_chars()

 

  for (i = uart->rx_dma_buf.tail; i != uart->rx_dma_buf.head; i++) {

    if (i >= UART_XMIT_SIZE)

      i = 0;

 

should be:

 

  for (i = uart->rx_dma_buf.tail; i != uart->rx_dma_buf.head; i++) {

    if (i >= UART_XMIT_SIZE) {

      if (uart->rx_dma_buf.head == 0)

        break;

      i = 0;

    }

 

Follow-ups

 

--- Sonic Zhang                                              2008-10-13 05:35:21

  for (i = uart->rx_dma_buf.tail; ; i++) {

    if (i >= UART_XMIT_SIZE)

      i = 0;

    if (i == uart->rx_dma_buf.head)

      break;

 

Should be a better fix.

 

Done.

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

No Files Were Found

Attachments

    Outcomes