[#4209] include/asm-blackfin/mach-bf561/dma.h contains bogus defines.

Document created by Aaronwu Employee on Aug 29, 2013
Version 1Show Document
  • View in full screen mode

[#4209] include/asm-blackfin/mach-bf561/dma.h contains bogus defines.

Submitted By: Simon Budig

Open Date

2008-07-01 09:31:36     Close Date

2008-07-17 06:59:46

Priority:

Medium     Assignee:

Michael Hennerich

Status:

Closed     Fixed In Release:

N/A

Found In Release:

2008R1-RC8     Release:

Category:

N/A     Board:

Custom

Processor:

BF561     Silicon Revision:

Is this bug repeatable?:

Yes     Resolution:

Assigned (Not Start)

Uboot version or rev.:

    Toolchain version or rev.:

App binary format:

N/A     

Summary: include/asm-blackfin/mach-bf561/dma.h contains bogus defines.

Details:

 

In include/asm-blackfin/mach-bf561/dma.h there are some bogus #defines:

 

#define CH_MEM_STREAM0_DEST     24       /* TX */

#define CH_MEM_STREAM0_SRC      25       /* RX */

#define CH_MEM_STREAM1_DEST     26       /* TX */

#define CH_MEM_STREAM1_SRC      27       /* RX */

#define CH_MEM_STREAM2_DEST     28

#define CH_MEM_STREAM2_SRC      29

#define CH_MEM_STREAM3_SRC      30

#define CH_MEM_STREAM3_DEST     31

 

Note how for CH_MEM_STREAM3_* source and destination are mixed up.

 

They AFAIK refer to the table in arch/blackfin/mach-bf561/dma.c, which contains

these:

 

        (struct dma_register *) MDMA1_D0_NEXT_DESC_PTR,  /* index no. 24 */

        (struct dma_register *) MDMA1_S0_NEXT_DESC_PTR,

        (struct dma_register *) MDMA1_D1_NEXT_DESC_PTR,

        (struct dma_register *) MDMA1_S1_NEXT_DESC_PTR,

        (struct dma_register *) MDMA2_D0_NEXT_DESC_PTR,

        (struct dma_register *) MDMA2_S0_NEXT_DESC_PTR,

        (struct dma_register *) MDMA2_D1_NEXT_DESC_PTR,

        (struct dma_register *) MDMA2_S1_NEXT_DESC_PTR,

 

Note how source and destination are alternating properly here.

 

The same problem affects the IMDMA-Channels a few lines later.

 

Patch is trivial and attached.

 

I have reported this earlier (unfortunately against u-boot) but it seems to have crept back in.

 

Follow-ups

 

--- Michael Hennerich                                        2008-07-17 07:36:59

Assign to me.

Michael

 

--- Michael Hennerich                                        2008-07-17 07:59:46

Hi Simon,

 

Thanks.

Applied on 2008R1 branch.

Same issue was fixed on svn/trunk some time ago.

 

-Michael

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

dma-patch.diff    text/x-patch    769    Simon Budig

Attachments

Outcomes