2010-08-03 01:03:58     unaligned under Blackfin

Document created by Aaronwu Employee on Aug 22, 2013
Version 1Show Document
  • View in full screen mode

2010-08-03 01:03:58     unaligned under Blackfin

Wojtek Skulski (UNITED STATES)

Message: 92082   

 

Is the functions __get_unaligned_4_le()  supported under Blackfin kernel? I searched for "unaligned" in Wiki and I understand that unaligned access is used as one of methods to catch runtime bugs. I would speculate that   __get_unaligned_4_le()   and the family can be used to allow the intentional unaligned access. But it does not seem to be implemented. Is it just my oversight that I cannot find it, or is it intentional?

QuoteReplyEditDelete

 

 

2010-08-03 02:15:39     Re: unaligned under Blackfin

Mike Frysinger (UNITED STATES)

Message: 92084   

 

all of the standard asm/unaligned.h functions should be supported

QuoteReplyEditDelete

 

 

2010-08-03 10:13:21     Re: unaligned under Blackfin

Wojtek Skulski (UNITED STATES)

Message: 92106   

 

do not seem to be supported

 

drivers/net/ax88180.c: In function 'AX_READ_FIFO':

drivers/net/ax88180.c:177: error: implicit declaration of function '__put_unaligned_4_le'

drivers/net/ax88180.c: In function 'AX_WRITE_FIFO':

drivers/net/ax88180.c:187: error: implicit declaration of function '__get_unaligned_4_le'

drivers/net/ax88180.c: In function 'ax88180_open':

QuoteReplyEditDelete

 

 

2010-08-03 10:30:45     Re: unaligned under Blackfin

Michael Hennerich (GERMANY)

Message: 92107    > '__put_unaligned_4_le'

 

This is not a generic function - that is only something arm arch uses.

(and BTW a good example why this driver won't be accepted)

 

Depending on the use case:

 

You need to either use:

put_unaligned_cpu32

put_unaligned_le32 or put_unaligned_be32

QuoteReplyEditDelete

 

 

2010-08-03 10:54:16     Re: unaligned under Blackfin

Wojtek Skulski (UNITED STATES)

Message: 92108   

 

Michael:

 

thanks a lot! Your comment is very helpful. They are working on cleaning up the driver and asking me those questions which they should be able to ask and get answered here. I am now serving as a messenger, which is a bit strange.

 

Thanks a lot! I will now pass this mesaage to them.

QuoteReplyEditDelete

 

 

2010-08-03 12:59:22     Re: unaligned under Blackfin

Mike Frysinger (UNITED STATES)

Message: 92115   

 

... which they should be able to ask & get answered on the standard mainline mailing lists like netdev or lkml

QuoteReplyEditDelete

 

 

2010-08-03 13:07:13     Re: unaligned under Blackfin

Robin Getz (UNITED STATES)

Message: 92117   

 

... which they would if they were really interested in main-lining the driver.

QuoteReplyEditDelete

 

 

2010-08-03 14:19:13     Re: unaligned under Blackfin

Wojtek Skulski (UNITED STATES)

Message: 92119   

 

Robin:

 

I am trying to help. Do not blame for what I am not responsible for. I can only say that they got to work after my first e-mail, sent me the driver, and were very surprised to hear that Blackfin port has had any problems. They seem to be devoted, responsible, and hard working on their stuff. Now they are working and I am trying to help. Not sure why they were painted in dark colors. My impression is very positive.

QuoteReplyEditDelete

 

 

2010-08-03 14:28:16     Re: unaligned under Blackfin

Mike Frysinger (UNITED STATES)

Message: 92121   

 

new people, different priorities, who knows.  at the time of our attempts, it was useless, and so they were punted.  perhaps you'll be able to convince them to get into mainline in which case it'll be trivial for us to import into our tree.

QuoteReplyEditDelete

 

 

2010-08-03 14:32:13     Re: unaligned under Blackfin

Robin Getz (UNITED STATES)

Message: 92122   

 

Wojtek:

 

I'm not blaming you - nor saying anything about the work _you_ have done. I understand that you aren't writing the driver.

 

Our impression was from 12 months ago - alot can change in that time - but it doesn't explain why they haven't send the driver to netdev? and I know I'm asking the wrong person - and I'm not asking you to be the middle man either.

 

If they get it working/accepted by Linus - great - we will add it during our kernel upgrade process sometime in the future (post 2010 release).

 

-Robin

QuoteReplyEditDelete

 

 

2010-08-03 15:34:00     Re: unaligned under Blackfin

Wojtek Skulski (UNITED STATES)

Message: 92127   

 

Robin and Mike: I think I can answer the question "why". They seem to be a bit lost concerning the proper procedures. Just like myself. I did not know about "checkpatch" and they probably did not know either. I passed this info to them. (Thanks a lot, Robin.) They probably were devoting all their time to their own implementation, just like I devoted my time to my board. But there is a larger world out there, which can be surprising when one is trying for the first time. We are all learning at some point. You are further down the learning curve than either I or they.

QuoteReplyEditDelete

 

 

2010-08-03 16:44:04     Re: unaligned under Blackfin

Robin Getz (UNITED STATES)

Message: 92129   

 

Wojtek:

 

I'm glad things appear to be going better now - but we pointed these things out years ago as well. Hopefully they understand the value of getting into mainline more than they did in the past - but it is customers like you driving them towards that - not vendors like us.

 

-Robin

Attachments

    Outcomes