2009-07-25 11:53:15     BF548-EZKIT uncorrect use of fb_var_sreeninfo.height/.width

Document created by Aaronwu Employee on Aug 16, 2013
Version 1Show Document
  • View in full screen mode

2009-07-25 11:53:15     BF548-EZKIT uncorrect use of fb_var_sreeninfo.height/.width

Stefan Pledl (GERMANY)

Message: 78037   

 

I think we have to use the physical dimensions [mm] of the display for .width and .heigth

in struct bfin_bf54xfb_mach_info bf54x_lq043_data which are copied to fbinfo->var.height/.width

in bf54x-lq043fb.c

 

linux/fb.h describes this values as 'height/weight of picture in mm'

 

Otherwise Qt calcs the wrong dpi value and the displayed fonts are very small.

 

diff --git a/arch/blackfin/mach-bf548/boards/ezkit.c b/arch/blackfin/mach-bf548/boards/ezkit.c

index 4827538..105d953 100644

--- a/arch/blackfin/mach-bf548/boards/ezkit.c

+++ b/arch/blackfin/mach-bf548/boards/ezkit.c

@@ -100,8 +100,8 @@ static struct platform_device bfin_isp1760_device = {

#include <mach/bf54x-lq043.h>

 

static struct bfin_bf54xfb_mach_info bf54x_lq043_data = {

-    .width =    480,

-    .height =    272,

+    .width =    95,

+    .height =    54,

     .xres =        {480, 480, 480},

     .yres =        {272, 272, 272},

     .bpp =        {24, 24, 24},

 

 

 

linux/fb.h

..

struct fb_var_screeninfo {

..

    __u32 height;            /* height of picture in mm    */

    __u32 width;            /* width of picture in mm     */

..

}

 

 

Best regards

Stefan

QuoteReplyEditDelete

 

 

2009-07-25 23:39:58     Re: BF548-EZKIT uncorrect use of fb_var_sreeninfo.height/.width

Robin Getz (UNITED STATES)

Message: 78043   

 

Stefan:

 

Looks correct to me - I'll apply to trunk and the branch on Monday.

 

-Robin

QuoteReplyEditDelete

 

 

2009-07-29 04:10:30     Re: BF548-EZKIT uncorrect use of fb_var_sreeninfo.height/.width

Michael Hennerich (GERMANY)

Message: 78137   

 

Hi Stefan,

 

 

 

Applied to trunk and branch 2009R1

 

Thanks!

 

 

 

-Michael

Attachments

    Outcomes