2009-04-17 08:59:23     Can't compile SVN kernel with CONFIG_DEBUG_SHIRQ

Document created by Aaronwu Employee on Aug 15, 2013
Version 1Show Document
  • View in full screen mode

2009-04-17 08:59:23     Can't compile SVN kernel with CONFIG_DEBUG_SHIRQ

Jean-Francois Argentino (FRANCE)

Message: 72776   

 

Hello,

 

When compiling the the SVN kernel with the CONFIG_DEBUG_SHIRQ set, the kernel crash when calling "request_irq" in the bfin_mac driver (bfin_mac_probe).

 

I think that's because the IRQ handler is called when it's registered but the "current_rx_ptr" global descriptor isn't initialized yet. Is it possible to call "desc_list_init" before requesting the IRQ?

TranslateQuoteReplyEditDelete

 

 

2009-04-17 10:13:04     Can't compile SVN kernel with CONFIG_DEBUG_SHIRQ

Michael Hennerich (GERMANY)

Message: 72781    >Is it possible to call "desc_list_init" before requesting the IRQ?

 

Yes - However there maybe other problems then.

I don't see a reason why the Blackfin On-Chip MAC IRQ is requested with

the IRQF_SHARED flag set.

This doesn't make much sense to me.

 

I would simply remove the IRQF_SHARED flag.

 

-Michael

 

Index: bfin_mac.c

===================================================================

--- bfin_mac.c (revision 6266)

+++ bfin_mac.c (working copy)

@@ -1041,7 +1041,7 @@

/* now, enable interrupts */

/* register irq handler */

rc = request_irq(IRQ_MAC_RX, bfin_mac_interrupt,

- IRQF_DISABLED | IRQF_SHARED, "EMAC_RX", ndev);

+ IRQF_DISABLED, "EMAC_RX", ndev);

if (rc) {

dev_err(&pdev->dev, "Cannot request Blackfin MAC RX

IRQ!\n");

rc = -EBUSY;

 

QuoteReplyEditDelete

 

 

2009-04-17 11:28:33     Re: Can't compile SVN kernel with CONFIG_DEBUG_SHIRQ

Jean-Francois Argentino (FRANCE)

Message: 72785   

 

OK, i get it.

TranslateQuoteReplyEditDelete

 

 

2009-04-17 17:04:41     Re: Can't compile SVN kernel with CONFIG_DEBUG_SHIRQ

Michael Hennerich (GERMANY)

Message: 72805    BTW Thanks for pointing this issue out.

Fixed in SVN rev 6276

 

-Michael

Attachments

    Outcomes