2009-02-03 11:43:47     isp1760 USB got broken between r5260 and r6039

Document created by Aaronwu Employee on Aug 9, 2013
Version 1Show Document
  • View in full screen mode

2009-02-03 11:43:47     isp1760 USB got broken between r5260 and r6039

Ivan Kuten (BELARUS)

Message: 68784   

 

Hello,

 

In our tests (with USB Flash 4Gb) isp1760 got broken somewhere between r5620 and r6039.

 

Here is our board specific setup:

 

#define ISP1761_BASE       0x20000000

#define ISP1761_IRQ        IRQ_PG8

 

#if defined(CONFIG_USB_ISP1760_HCD) || defined(CONFIG_USB_ISP1760_HCD_MODULE)

#include <linux/usb/isp1760.h>

static struct resource bfin_isp1760_resources[] = {

        [0] = {

                .start  = ISP1761_BASE,

                .end    = ISP1761_BASE + 0x000fffff,

                .flags  = IORESOURCE_MEM,

        },

        [1] = {

                .start  = ISP1761_IRQ,

                .end    = ISP1761_IRQ,

                .flags  = IORESOURCE_IRQ,

        },

};

 

static struct isp1760_platform_data isp1760_priv = {

        .is_isp1761 = 0,

        .port1_disable = 0,

        .bus_width_16 = 1,

        .port1_otg = 0,

        .analog_oc = 0,

        .dack_polarity_high = 0,

        .dreq_polarity_high = 0,

};

 

 

 

Here what we have in r5620:

 

isp1760-hcd isp1760-hcd.0: NXP ISP1760 USB Host Controller

isp1760-hcd isp1760-hcd.0: new USB bus registered, assigned bus number 1

isp1760-hcd isp1760-hcd.0: bus width: 16, oc: digital

isp1760-hcd isp1760-hcd.0: irq 74, io mem 0x20000000

isp1760-hcd isp1760-hcd.0: USB ISP 1761 HW rev. 1 started

usb usb1: configuration #1 chosen from 1 choice

hub 1-0:1.0: USB hub found

hub 1-0:1.0: 1 port detected

usb usb1: New USB device found, idVendor=1d6b, idProduct=0002

usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1

usb usb1: Product: NXP ISP1760 USB Host Controller

usb usb1: Manufacturer: Linux 2.6.28-rc2-ADI-2009R1-pre isp1760-hcd

usb usb1: SerialNumber: isp1760-hcd.0

Initializing USB Mass Storage driver...

usbcore: registered new interface driver usb-storage

USB Mass Storage support registered.

Freeing unused kernel memory: 2704k freed

port 1 high speed

usb 1-1: new high speed USB device using isp1760-hcd and address 2

port 1 high speed

usb 1-1: configuration #1 chosen from 1 choice

hub 1-1:1.0: USB hub found

hub 1-1:1.0: 3 ports detected

usb 1-1: New USB device found, idVendor=0471, idProduct=3526

usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0

usb 1-1: Product: ISP1520

usb 1-1: Manufacturer: Philips Semiconductors

usb 1-1.2: new high speed USB device using isp1760-hcd and address 3

usb 1-1.2: configuration #1 chosen from 1 choice

scsi0 : SCSI emulation for USB Mass Storage devices

usb-storage: device found at 3

usb-storage: waiting for device to settle before scanning

usb 1-1.2: New USB device found, idVendor=0930, idProduct=6545

usb 1-1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3

usb 1-1.2: Product: TransMemory

usb 1-1.2: Manufacturer: TOSHIBA

usb 1-1.2: SerialNumber: 5B82160002DD

scsi 0:0:0:0: Direct-Access     TOSHIBA  TransMemory      PMAP PQ: 0 ANSI: 0 CCS

sd 0:0:0:0: [sda] 7823360 512-byte hardware sectors: (4.00 GB/3.73 GiB)

sd 0:0:0:0: [sda] Write Protect is off

sd 0:0:0:0: [sda] Mode Sense: 23 00 00 00

sd 0:0:0:0: [sda] Assuming drive cache: write through

sd 0:0:0:0: [sda] 7823360 512-byte hardware sectors: (4.00 GB/3.73 GiB)

sd 0:0:0:0: [sda] Write Protect is off

sd 0:0:0:0: [sda] Mode Sense: 23 00 00 00

sd 0:0:0:0: [sda] Assuming drive cache: write through

sda: sda1

sd 0:0:0:0: [sda] Attached SCSI removable disk

usb-storage: device scan complete

usb 1-1.2: USB disconnect, address 3

 

 

 

Here is what we have in r6039:

 

isp1760-hcd isp1760-hcd.0: new USB bus registered, assigned bus number 1

isp1760-hcd isp1760-hcd.0: bus width: 16, oc: digital

isp1760-hcd isp1760-hcd.0: irq 74, io mem 0x20000000

isp1760-hcd isp1760-hcd.0: USB ISP 1761 HW rev. 1 started

usb usb1: default language 0x0409

usb usb1: usb_probe_device

usb usb1: configuration #1 chosen from 1 choice

usb usb1: adding 1-0:1.0 (config #1, interface 0)

hub 1-0:1.0: usb_probe_interface

hub 1-0:1.0: usb_probe_interface - got id

hub 1-0:1.0: USB hub found

hub 1-0:1.0: 1 port detected

hub 1-0:1.0: standalone hub

hub 1-0:1.0: individual port power switching

hub 1-0:1.0: individual port over-current protection

hub 1-0:1.0: power on to power good time: 20ms

hub 1-0:1.0: local power source is good

hub 1-0:1.0: enabling power on all ports

drivers/usb/core/inode.c: creating file '001'

usb usb1: New USB device found, idVendor=1d6b, idProduct=0002

usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1

usb usb1: Product: NXP ISP1760 USB Host Controller

usb usb1: Manufacturer: Linux 2.6.28-ADI-2009R1-pre isp1760-hcd

usb usb1: SerialNumber: isp1760-hcd.0

driver_register ret 0

Initializing USB Mass Storage driver...

driver_register ret 0

usbcore: registered new interface driver usb-storage

USB Mass Storage support registered.

hub 1-0:1.0: port 1: status 0501 change 0001

Freeing unused kernel memory: 2724k freed

hub 1-0:1.0: state 7 ports 1 chg 0002 evt 0000

hub 1-0:1.0: port 1, status 0501, change 0000, 480 Mb/s

port 1 high speed

usb 1-1: new high speed USB device using isp1760-hcd and address 2

usb 1-1: khubd timed out on ep0out len=0/0

usb 1-1: khubd timed out on ep0out len=0/0

usb 1-1: device not accepting address 2, error -110

port 1 high speed

usb 1-1: new high speed USB device using isp1760-hcd and address 3

usb 1-1: khubd timed out on ep0out len=0/0

usb 1-1: khubd timed out on ep0out len=0/0

usb 1-1: device not accepting address 3, error -110

port 1 high speed

usb 1-1: new high speed USB device using isp1760-hcd and address 4

# port 1 high speed

usb 1-1: device descriptor read/64, error -110

port 1 high speed

usb 1-1: device descriptor read/64, error -110

port 1 high speed

usb 1-1: new high speed USB device using isp1760-hcd and address 5

 

 

 

Regards,

 

Ivan

QuoteReplyEditDelete

 

 

2009-02-03 11:59:20     Re: isp1760 USB got broken between r5260 and r6039

Michael Hennerich (GERMANY)

Message: 68785   

 

Ivan,

 

can you try adding proper IRQ FLAGS in our board setup ?

 

       .flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,

 

Between these two revisions I added code into the driver actually using these ...

 

-Michael

QuoteReplyEditDelete

 

 

2009-02-03 13:37:36     Re: isp1760 USB got broken between r5260 and r6039

Ivan Kuten (BELARUS)

Message: 68796   

 

Thanks for hint!

 

this ".flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL," fixed behaviour for USB Flash.

 

Probably it should be added into generic_board.c as well for people know that they should indicate irq level in flags.

 

However still have problems with USB WLAN module and "Reloading ptd 01b041e0/01a3b6e0... qh 01b05368 readed: 0 of 2500 done: 00020000 cur: 00010000" mentioned in https://blackfin.uclinux.org/gf/project/uclinux-dist/forum/?action=ForumBrowse&forum_id=39&_forum_action=ForumMessageBrowse&thread_id=30804

 

Regards,

 

Ivan

 

 

QuoteReplyEditDelete

 

 

2009-02-03 13:42:49     Re: isp1760 USB got broken between r5260 and r6039

Mike Frysinger (UNITED STATES)

Message: 68797   

 

i think we'll just drop the generic board files

QuoteReplyEditDelete

 

 

2009-02-04 03:34:18     Re: isp1760 USB got broken between r5260 and r6039

Michael Hennerich (GERMANY)

Message: 68812   

 

Ivan,

 

This is a problem somewhere in the driver.

I reported this to the maintainer before - and as far I know similar issues are also seen on PPC.

You need to complain to the maintainer of the isp1760-hcd driver.

 

-Michael

QuoteReplyEditDelete

 

 

2009-02-04 09:27:35     Re: isp1760 USB got broken between r5260 and r6039

Ivan Kuten (BELARUS)

Message: 68851   

 

OK,

 

I will post to linux usb and probably linux-wireless

 

Regards,

 

Ivan

Attachments

    Outcomes