2008-09-23 06:57:40     Bugs in the SVN PPI driver? And if so, the better way to report them.

Document created by Aaronwu Employee on Aug 7, 2013
Version 1Show Document
  • View in full screen mode

2008-09-23 06:57:40     Bugs in the SVN PPI driver? And if so, the better way to report them.

Jean-Francois Argentino (FRANCE)

Message: 62551   

 

Hello,

 

I think there's 2 bugs in the SVN version of the "bfin_ppi.c" driver:

 

1°) In "ppi_read" and "ppi_write", the PPI_COUNT and PPI_FRAME aren't updated if not in CFG_PPI_DIMS_2D mode.

 

2°) In "ppi_read", whatever is the synchronization mode, we disable only the TIMER0, due to line 678.

 

 

 

So some questions before reporting them:

 

1°) Do I'm right ? I just begin to play with the PPI so I'm not totally sure.

 

2°) There's 2 differents bugs, is it better to report them in 2 differents trackers?

 

3°) As I can't fully test my correction, do I better to just report bug(s), or send my patches even if they aren't fully tested?

 

 

 

Thanks.

TranslateQuoteReplyEditDelete

 

 

2008-09-26 05:11:00     Re: Bugs in the SVN PPI driver? And if so, the better way to report them.

Yi Li (CHINA)

Message: 62785   

 

>So some questions before reporting them:

 

>1°) Do I'm right ? I just begin to play with the PPI so I'm not totally sure.

 

If  you have done some investigation, it is OK to open a bug in the bug tracker - so it get tracked an will not get lost. If the bug assignee think the bug is invalid, the bug will be rejected. But it is OK to report.

 

>2°) There's 2 differents bugs, is it better to report them in 2 differents trackers?

 

Yes. Please report 2 bug, each bug focus on one issue.

 

 

 

>3°) As I can't fully test my correction, do I better to just report bug(s), or send my patches even if they aren't fully >tested?

 

Please attach the patch in the bug tracker.

Attachments

    Outcomes