[#6143] urjtag ice100b cable driver should be using global frequency
Submitted By: Mike Frysinger
N/A Silicon Revision:
Under Debugging Fixed In Release:
Host Operating System:
Open Found In Release:
Is this bug repeatable?:
Summary: urjtag ice100b cable driver should be using global frequency
the ice100b cable driver currently ignores cable->frequency and instead uses a local "cur_freq" variable. but it should be setting this during the init and set_freq functions. that way the common "frequency" command works properly. note that the way the current ice100b driver is written, you should only have to upset the set_freq functions because the respective init functions call those to handle things.
also, i think the ice100b can only support a few different frequency ranges ? in that case, the set_freq function should take the input, truncate it down to the next lowest available value, set the freq to that, and then set cable->frequency to that new value.
--- Jie Zhang 2011-07-27 08:44:59
--- Mike Frysinger 2011-07-27 20:28:08
i dont think it is quite done ... i dont think "cur_freq" should exist
at all. atm, if you use the urjtag command "frequency", the new
frequency is not utilized.
--- Jie Zhang 2011-07-27 21:03:08
My first patch was actually trying to remove cur_freq. But I later found the one
I committed is cleaner. I tested and command "frequency" works for me.
Could you clarify it for me? Thank you!
File Name File Type File Size Posted By
No Files Were Found