[#6143] urjtag ice100b cable driver should be using global frequency

Document created by Aaronwu Employee on Oct 17, 2013
Version 1Show Document
  • View in full screen mode

[#6143] urjtag ice100b cable driver should be using global frequency

Submitted By: Mike Frysinger

Open Date

2010-07-31 00:23:11    

Priority:

Medium     Assignee:

Jeff Bartlett

Chad Wentworth

Jie Zhang

Board:

N/A     Silicon Revision:

Resolution:

Under Debugging     Fixed In Release:

N/A

Processor:

ALL     

Host Operating System:

toolchain rev.:

    kernel rev.:

State:

Open     Found In Release:

N/A

Is this bug repeatable?:

N/A     

Summary: urjtag ice100b cable driver should be using global frequency

Details:

 

the ice100b cable driver currently ignores cable->frequency and instead uses a local "cur_freq" variable.  but it should be setting this during the init and set_freq functions.  that way the common "frequency" command works properly.  note that the way the current ice100b driver is written, you should only have to upset the set_freq functions because the respective init functions call those to handle things.

 

also, i think the ice100b can only support a few different frequency ranges ?  in that case, the set_freq function should take the input, truncate it down to the next lowest available value, set the freq to that, and then set cable->frequency to that new value.

 

Follow-ups

 

--- Jie Zhang                                                2011-07-27 08:44:59

Fixed now.

 

--- Mike Frysinger                                           2011-07-27 20:28:08

i dont think it is quite done ... i dont think "cur_freq" should exist

at all.  atm, if you use the urjtag command "frequency", the new

frequency is not utilized.

 

--- Jie Zhang                                                2011-07-27 21:03:08

My first patch was actually trying to remove cur_freq. But I later found the one

I committed is cleaner. I tested and command "frequency" works for me.

Could you clarify it for me? Thank you!

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

No Files Were Found

Attachments

    Outcomes