[#6321] libbfdsp sqrt funcs do not respect FDPIC ABI for data loads
Submitted By: Steve Kilbane
N/A Silicon Revision:
N/A Fixed In Release:
Host Operating System:
Open Found In Release:
Is this bug repeatable?:
Summary: libbfdsp sqrt funcs do not respect FDPIC ABI for data loads
The functions in libbfdsp are taken from VisualDSP++ largely unchanged, and therefore do not respect the FDPIC ABI (since FDPIC is not supported in VisualDSP++, it wasn't a requirement when the functions were written). Consequently, the functions need revising to ensure they are FDPIC-safe.
--- Mike Frysinger 2010-11-02 05:01:14
can you provide some actual examples of where you see the ABI being violated ?
simply utilizing the P3 register is not a violation of the ABI.
--- Steve Kilbane 2010-11-03 05:06:57
Not right now, beyond the thread at:
This is more by way of warning that there could be lurking problems.
--- Mike Frysinger 2010-11-09 05:41:41
generalities should be avoided. if you grep the tree, you'll see most data
loads do support FDPIC already. it seems only the square root funcs were
ive fixed up the obvious ones, but ___SQRT_Seed_Table is still broken. the
usage of loading up the pointer ___SQRT_Seed_Table-0x20 seems odd to me. i dont
know why the -0x20 is there, nor does libbfdsp apparently have any testsuites to
validate it so i dont want to go changing anything without that.
File Name File Type File Size Posted By
No Files Were Found