[#6321] libbfdsp sqrt funcs do not respect FDPIC ABI for data loads

Document created by Aaronwu Employee on Oct 17, 2013
Version 1Show Document
  • View in full screen mode

[#6321] libbfdsp sqrt funcs do not respect FDPIC ABI for data loads

Submitted By: Steve Kilbane

Open Date

2010-10-29 03:24:31    

Priority:

Medium     Assignee:

Nobody

Board:

N/A     Silicon Revision:

Resolution:

N/A     Fixed In Release:

N/A

Processor:

ALL     

Host Operating System:

toolchain rev.:

    kernel rev.:

State:

Open     Found In Release:

2010R1-RC4

Is this bug repeatable?:

yes     

Summary: libbfdsp sqrt funcs do not respect FDPIC ABI for data loads

Details:

 

The functions in libbfdsp are taken from VisualDSP++ largely unchanged, and therefore do not respect the FDPIC ABI (since FDPIC is not supported in VisualDSP++, it wasn't a requirement when the functions were written). Consequently, the functions need revising to ensure they are FDPIC-safe.

 

Follow-ups

 

--- Mike Frysinger                                           2010-11-02 05:01:14

can you provide some actual examples of where you see the ABI being violated ?

simply utilizing the P3 register is not a violation of the ABI.

 

--- Steve Kilbane                                            2010-11-03 05:06:57

Not right now, beyond the thread at:

 

http://blackfin.uclinux.org/gf/project/toolchain/forum/?_forum_action=ForumMessageBrowse&thread_id=32544&action=ForumBrowse&forum_id=44

 

This is more by way of warning that there could be lurking problems.

 

--- Mike Frysinger                                           2010-11-09 05:41:41

generalities should be avoided.  if you grep the tree, you'll see most data

loads do support FDPIC already.  it seems only the square root funcs were

missed.

 

ive fixed up the obvious ones, but ___SQRT_Seed_Table is still broken.  the

usage of loading up the pointer ___SQRT_Seed_Table-0x20 seems odd to me.  i dont

know why the -0x20 is there, nor does libbfdsp apparently have any testsuites to

validate it so i dont want to go changing anything without that.

 

 

 

    Files

    Changes

    Commits

    Dependencies

    Duplicates

    Associations

    Tags

 

File Name     File Type     File Size     Posted By

No Files Were Found

Attachments

    Outcomes